Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignition #525

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Remove ignition #525

merged 3 commits into from
Oct 25, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 28, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig
Remove ignition
7d522e6 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from marcoag as a code owner July 28, 2023 04:10
@nkoenig nkoenig marked this pull request as draft July 28, 2023 04:10
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #525 (9cd33e3) into main (2765c5f) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cd33e3 differs from pull request most recent head 9a3b38e. Consider uploading reports for the commit 9a3b38e to get more accurate results

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          79       79           
  Lines       10213    10213           
=======================================
  Hits         8542     8542           
  Misses       1671     1671
Files Coverage Δ
graphics/src/AssimpLoader.cc 96.41% <ø> (ø)

@mjcarroll mjcarroll marked this pull request as ready for review October 25, 2023 14:37
@mjcarroll mjcarroll merged commit 7d88e7f into main Oct 25, 2023
8 checks passed
@mjcarroll mjcarroll deleted the nkoenig/remove-ign branch October 25, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@marcoag marcoag Awaiting requested review from marcoag marcoag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @mjcarroll